[Tests] Streamline

symfony · Oct 31, 2023 · eb1bcaf · eb1bcaf
1 parent 338638e
commit eb1bcaf
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/Tests/Compiler/CheckTypeDeclarationsPassTest.php b/Tests/Compiler/CheckTypeDeclarationsPassTest.php
@@ -265,17 +265,15 @@ public function testProcessSuccessWhenPassingNullToOptionalThatDoesNotAcceptNull
 
     public function testProcessFailsWhenPassingBadTypeToOptional()
     {
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('Invalid definition for service "bar": argument 1 of "Symfony\\Component\\DependencyInjection\\Tests\\Fixtures\\CheckTypeDeclarationsPass\\BarOptionalArgument::__construct()" accepts "stdClass", "string" passed.');
-
         $container = new ContainerBuilder();
 
         $container->register('bar', BarOptionalArgument::class)
             ->addArgument('string instead of stdClass');
 
-        (new CheckTypeDeclarationsPass(true))->process($container);
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('Invalid definition for service "bar": argument 1 of "Symfony\\Component\\DependencyInjection\\Tests\\Fixtures\\CheckTypeDeclarationsPass\\BarOptionalArgument::__construct()" accepts "stdClass", "string" passed.');
 
-        $this->assertNull($container->get('bar')->foo);
+        (new CheckTypeDeclarationsPass(true))->process($container);
     }
 
     public function testProcessSuccessScalarType()
@@ -604,17 +602,15 @@ public function testProcessDoesNotThrowsExceptionOnValidTypes()
 
     public function testProcessThrowsOnIterableTypeWhenScalarPassed()
     {
-        $this->expectException(InvalidArgumentException::class);
-        $this->expectExceptionMessage('Invalid definition for service "bar_call": argument 1 of "Symfony\\Component\\DependencyInjection\\Tests\\Fixtures\\CheckTypeDeclarationsPass\\BarMethodCall::setIterable()" accepts "iterable", "int" passed.');
-
         $container = new ContainerBuilder();
 
         $container->register('bar_call', BarMethodCall::class)
             ->addMethodCall('setIterable', [2]);
 
-        (new CheckTypeDeclarationsPass(true))->process($container);
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('Invalid definition for service "bar_call": argument 1 of "Symfony\\Component\\DependencyInjection\\Tests\\Fixtures\\CheckTypeDeclarationsPass\\BarMethodCall::setIterable()" accepts "iterable", "int" passed.');
 
-        $this->assertInstanceOf(\stdClass::class, $container->get('bar')->foo);
+        (new CheckTypeDeclarationsPass(true))->process($container);
     }
 
     public function testProcessResolveExpressions()