Use ::class keyword when possible

symfony · Jan 11, 2021 · edfa86f · edfa86f
1 parent 462dbe3
commit edfa86f
Show file tree

Hide file tree

Showing 8 changed files with 26 additions and 26 deletions.
diff --git a/DebugClassLoader.php b/DebugClassLoader.php
@@ -90,8 +90,8 @@ public function getClassLoader()
     public static function enable()
     {
         // Ensures we don't hit https://bugs.php.net/42098
-        class_exists('Symfony\Component\Debug\ErrorHandler');
-        class_exists('Psr\Log\LogLevel');
+        class_exists(\Symfony\Component\Debug\ErrorHandler::class);
+        class_exists(\Psr\Log\LogLevel::class);
 
         if (!\is_array($functions = spl_autoload_functions())) {
             return;

diff --git a/ErrorHandler.php b/ErrorHandler.php
@@ -169,7 +169,7 @@ public function __construct(BufferingLogger $bootstrappingLogger = null)
             $this->bootstrappingLogger = $bootstrappingLogger;
             $this->setDefaultLogger($bootstrappingLogger);
         }
-        $this->traceReflector = new \ReflectionProperty('Exception', 'trace');
+        $this->traceReflector = new \ReflectionProperty(\Exception::class, 'trace');
         $this->traceReflector->setAccessible(true);
     }
 

diff --git a/Exception/FatalErrorException.php b/Exception/FatalErrorException.php
@@ -74,7 +74,7 @@ public function __construct(string $message, int $code, int $severity, string $f
 
     protected function setTrace($trace)
     {
-        $traceReflector = new \ReflectionProperty('Exception', 'trace');
+        $traceReflector = new \ReflectionProperty(\Exception::class, 'trace');
         $traceReflector->setAccessible(true);
         $traceReflector->setValue($this, $trace);
     }

diff --git a/Tests/DebugClassLoaderTest.php b/Tests/DebugClassLoaderTest.php
@@ -54,7 +54,7 @@ public function testIdempotence()
                 $reflProp = $reflClass->getProperty('classLoader');
                 $reflProp->setAccessible(true);
 
-                $this->assertNotInstanceOf('Symfony\Component\Debug\DebugClassLoader', $reflProp->getValue($function[0]));
+                $this->assertNotInstanceOf(DebugClassLoader::class, $reflProp->getValue($function[0]));
 
                 return;
             }
@@ -65,7 +65,7 @@ public function testIdempotence()
 
     public function testThrowingClass()
     {
-        $this->expectException('Exception');
+        $this->expectException(\Exception::class);
         $this->expectExceptionMessage('boo');
         try {
             class_exists(Fixtures\Throwing::class);
@@ -80,14 +80,14 @@ class_exists(Fixtures\Throwing::class);
 
     public function testNameCaseMismatch()
     {
-        $this->expectException('RuntimeException');
+        $this->expectException(\RuntimeException::class);
         $this->expectExceptionMessage('Case mismatch between loaded and declared class names');
         class_exists(TestingCaseMismatch::class, true);
     }
 
     public function testFileCaseMismatch()
     {
-        $this->expectException('RuntimeException');
+        $this->expectException(\RuntimeException::class);
         $this->expectExceptionMessage('Case mismatch between class and real file names');
         if (!file_exists(__DIR__.'/Fixtures/CaseMismatch.php')) {
             $this->markTestSkipped('Can only be run on case insensitive filesystems');
@@ -98,7 +98,7 @@ class_exists(Fixtures\CaseMismatch::class, true);
 
     public function testPsr4CaseMismatch()
     {
-        $this->expectException('RuntimeException');
+        $this->expectException(\RuntimeException::class);
         $this->expectExceptionMessage('Case mismatch between loaded and declared class names');
         class_exists(__NAMESPACE__.'\Fixtures\Psr4CaseMismatch', true);
     }
@@ -179,7 +179,7 @@ public function testDeprecatedSuperInSameNamespace()
         $e = error_reporting(0);
         trigger_error('', E_USER_NOTICE);
 
-        class_exists('Symfony\Bridge\Debug\Tests\Fixtures\ExtendsDeprecatedParent', true);
+        class_exists(\Symfony\Bridge\Debug\Tests\Fixtures\ExtendsDeprecatedParent::class, true);
 
         error_reporting($e);
         restore_error_handler();

diff --git a/Tests/ErrorHandlerTest.php b/Tests/ErrorHandlerTest.php
@@ -35,7 +35,7 @@ public function testRegister()
         $handler = ErrorHandler::register();
 
         try {
-            $this->assertInstanceOf('Symfony\Component\Debug\ErrorHandler', $handler);
+            $this->assertInstanceOf(ErrorHandler::class, $handler);
             $this->assertSame($handler, ErrorHandler::register());
 
             $newHandler = new ErrorHandler();
@@ -72,7 +72,7 @@ public function testRegister()
 
     public function testErrorGetLast()
     {
-        $logger = $this->getMockBuilder('Psr\Log\LoggerInterface')->getMock();
+        $logger = $this->getMockBuilder(\Psr\Log\LoggerInterface::class)->getMock();
         $handler = ErrorHandler::register();
         $handler->setDefaultLogger($logger);
         $handler->screamAt(\E_ALL);
@@ -150,7 +150,7 @@ public function testConstruct()
     public function testDefaultLogger()
     {
         try {
-            $logger = $this->getMockBuilder('Psr\Log\LoggerInterface')->getMock();
+            $logger = $this->getMockBuilder(\Psr\Log\LoggerInterface::class)->getMock();
             $handler = ErrorHandler::register();
 
             $handler->setDefaultLogger($logger, \E_NOTICE);
@@ -225,7 +225,7 @@ public function testHandleError()
             restore_error_handler();
             restore_exception_handler();
 
-            $logger = $this->getMockBuilder('Psr\Log\LoggerInterface')->getMock();
+            $logger = $this->getMockBuilder(\Psr\Log\LoggerInterface::class)->getMock();
 
             $warnArgCheck = function ($logLevel, $message, $context) {
                 $this->assertEquals('info', $logLevel);
@@ -250,7 +250,7 @@ public function testHandleError()
             restore_error_handler();
             restore_exception_handler();
 
-            $logger = $this->getMockBuilder('Psr\Log\LoggerInterface')->getMock();
+            $logger = $this->getMockBuilder(\Psr\Log\LoggerInterface::class)->getMock();
 
             $line = null;
             $logArgCheck = function ($level, $message, $context) use (&$line) {
@@ -355,7 +355,7 @@ public function testHandleDeprecation()
             $this->assertSame('User Deprecated: Foo deprecation', $exception->getMessage());
         };
 
-        $logger = $this->getMockBuilder('Psr\Log\LoggerInterface')->getMock();
+        $logger = $this->getMockBuilder(\Psr\Log\LoggerInterface::class)->getMock();
         $logger
             ->expects($this->once())
             ->method('log')
@@ -370,7 +370,7 @@ public function testHandleDeprecation()
     public function testHandleException()
     {
         try {
-            $logger = $this->getMockBuilder('Psr\Log\LoggerInterface')->getMock();
+            $logger = $this->getMockBuilder(\Psr\Log\LoggerInterface::class)->getMock();
             $handler = ErrorHandler::register();
 
             $exception = new \Exception('foo');
@@ -450,7 +450,7 @@ public function testBootstrappingLogger()
 
         $bootLogger->log(LogLevel::WARNING, 'Foo message', ['exception' => $exception]);
 
-        $mockLogger = $this->getMockBuilder('Psr\Log\LoggerInterface')->getMock();
+        $mockLogger = $this->getMockBuilder(\Psr\Log\LoggerInterface::class)->getMock();
         $mockLogger->expects($this->once())
             ->method('log')
             ->with(LogLevel::WARNING, 'Foo message', ['exception' => $exception]);
@@ -465,7 +465,7 @@ public function testSettingLoggerWhenExceptionIsBuffered()
 
         $exception = new \Exception('Foo message');
 
-        $mockLogger = $this->getMockBuilder('Psr\Log\LoggerInterface')->getMock();
+        $mockLogger = $this->getMockBuilder(\Psr\Log\LoggerInterface::class)->getMock();
         $mockLogger->expects($this->once())
             ->method('log')
             ->with(LogLevel::CRITICAL, 'Uncaught Exception: Foo message', ['exception' => $exception]);
@@ -480,7 +480,7 @@ public function testSettingLoggerWhenExceptionIsBuffered()
     public function testHandleFatalError()
     {
         try {
-            $logger = $this->getMockBuilder('Psr\Log\LoggerInterface')->getMock();
+            $logger = $this->getMockBuilder(\Psr\Log\LoggerInterface::class)->getMock();
             $handler = ErrorHandler::register();
 
             $error = [
@@ -527,13 +527,13 @@ public function testHandleErrorException()
 
         $handler->handleException($exception);
 
-        $this->assertInstanceOf('Symfony\Component\Debug\Exception\ClassNotFoundException', $args[0]);
+        $this->assertInstanceOf(\Symfony\Component\Debug\Exception\ClassNotFoundException::class, $args[0]);
         $this->assertStringStartsWith("Attempted to load class \"IReallyReallyDoNotExistAnywhereInTheRepositoryISwear\" from the global namespace.\nDid you forget a \"use\" statement", $args[0]->getMessage());
     }
 
     public function testCustomExceptionHandler()
     {
-        $this->expectException('Exception');
+        $this->expectException(\Exception::class);
         $handler = new ErrorHandler();
         $handler->setExceptionHandler(function ($e) use ($handler) {
             $handler->handleException($e);

diff --git a/Tests/FatalErrorHandler/ClassNotFoundFatalErrorHandlerTest.php b/Tests/FatalErrorHandler/ClassNotFoundFatalErrorHandlerTest.php
@@ -67,7 +67,7 @@ public function testHandleClassNotFound($error, $translatedMessage, $autoloader
             array_map('spl_autoload_register', $autoloaders);
         }
 
-        $this->assertInstanceOf('Symfony\Component\Debug\Exception\ClassNotFoundException', $exception);
+        $this->assertInstanceOf(\Symfony\Component\Debug\Exception\ClassNotFoundException::class, $exception);
         $this->assertMatchesRegularExpression($translatedMessage, $exception->getMessage());
         $this->assertSame($error['type'], $exception->getSeverity());
         $this->assertSame($error['file'], $exception->getFile());
@@ -218,6 +218,6 @@ public function testCannotRedeclareClass()
         $handler = new ClassNotFoundFatalErrorHandler();
         $exception = $handler->handleError($error, new FatalErrorException('', 0, $error['type'], $error['file'], $error['line']));
 
-        $this->assertInstanceOf('Symfony\Component\Debug\Exception\ClassNotFoundException', $exception);
+        $this->assertInstanceOf(\Symfony\Component\Debug\Exception\ClassNotFoundException::class, $exception);
     }
 }
diff --git a/Tests/FatalErrorHandler/UndefinedFunctionFatalErrorHandlerTest.php b/Tests/FatalErrorHandler/UndefinedFunctionFatalErrorHandlerTest.php
@@ -28,7 +28,7 @@ public function testUndefinedFunction($error, $translatedMessage)
         $handler = new UndefinedFunctionFatalErrorHandler();
         $exception = $handler->handleError($error, new FatalErrorException('', 0, $error['type'], $error['file'], $error['line']));
 
-        $this->assertInstanceOf('Symfony\Component\Debug\Exception\UndefinedFunctionException', $exception);
+        $this->assertInstanceOf(\Symfony\Component\Debug\Exception\UndefinedFunctionException::class, $exception);
         // class names are case insensitive and PHP do not return the same
         $this->assertSame(strtolower($translatedMessage), strtolower($exception->getMessage()));
         $this->assertSame($error['type'], $exception->getSeverity());

diff --git a/Tests/FatalErrorHandler/UndefinedMethodFatalErrorHandlerTest.php b/Tests/FatalErrorHandler/UndefinedMethodFatalErrorHandlerTest.php
@@ -28,7 +28,7 @@ public function testUndefinedMethod($error, $translatedMessage)
         $handler = new UndefinedMethodFatalErrorHandler();
         $exception = $handler->handleError($error, new FatalErrorException('', 0, $error['type'], $error['file'], $error['line']));
 
-        $this->assertInstanceOf('Symfony\Component\Debug\Exception\UndefinedMethodException', $exception);
+        $this->assertInstanceOf(\Symfony\Component\Debug\Exception\UndefinedMethodException::class, $exception);
         $this->assertSame($translatedMessage, $exception->getMessage());
         $this->assertSame($error['type'], $exception->getSeverity());
         $this->assertSame($error['file'], $exception->getFile());