Skip to content

Commit

Permalink
minor #49253 [PHPUnit 10] Use TestCase suffix for abstract tests in…
Browse files Browse the repository at this point in the history
… `/Tests/` (OskarStark)

This PR was merged into the 6.3 branch.

Discussion
----------

[PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Refs symfony/symfony#49233
| License       | MIT
| Doc PR        | n/a

Replaces #49234

Using `Test` suffix is deprecated since PHPUnit 10

Spotted in
* symfony/symfony#49233

Commits
-------

cb3db968e4 [PHPUnit 10] Use `TestCase` suffix for abstract tests in `/Tests/`
  • Loading branch information
nicolas-grekas committed Feb 7, 2023
1 parent 8ae1b60 commit 4b81c20
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\BufferedOutput;

abstract class AbstractDescriptorTest extends TestCase
abstract class AbstractDescriptorTestCase extends TestCase
{
/** @dataProvider getDescribeInputArgumentTestData */
public function testDescribeInputArgument(InputArgument $argument, $expectedDescription)
Expand Down
2 changes: 1 addition & 1 deletion Tests/Descriptor/JsonDescriptorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

use Symfony\Component\Console\Descriptor\JsonDescriptor;

class JsonDescriptorTest extends AbstractDescriptorTest
class JsonDescriptorTest extends AbstractDescriptorTestCase
{
protected function getDescriptor()
{
Expand Down
2 changes: 1 addition & 1 deletion Tests/Descriptor/MarkdownDescriptorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
use Symfony\Component\Console\Tests\Fixtures\DescriptorApplicationMbString;
use Symfony\Component\Console\Tests\Fixtures\DescriptorCommandMbString;

class MarkdownDescriptorTest extends AbstractDescriptorTest
class MarkdownDescriptorTest extends AbstractDescriptorTestCase
{
public static function getDescribeCommandTestData()
{
Expand Down
2 changes: 1 addition & 1 deletion Tests/Descriptor/TextDescriptorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
use Symfony\Component\Console\Tests\Fixtures\DescriptorApplicationMbString;
use Symfony\Component\Console\Tests\Fixtures\DescriptorCommandMbString;

class TextDescriptorTest extends AbstractDescriptorTest
class TextDescriptorTest extends AbstractDescriptorTestCase
{
public static function getDescribeCommandTestData()
{
Expand Down
2 changes: 1 addition & 1 deletion Tests/Descriptor/XmlDescriptorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

use Symfony\Component\Console\Descriptor\XmlDescriptor;

class XmlDescriptorTest extends AbstractDescriptorTest
class XmlDescriptorTest extends AbstractDescriptorTestCase
{
protected function getDescriptor()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
use PHPUnit\Framework\TestCase;
use Symfony\Component\Console\Input\StreamableInputInterface;

abstract class AbstractQuestionHelperTest extends TestCase
abstract class AbstractQuestionHelperTestCase extends TestCase
{
protected function createStreamableInputInterfaceMock($stream = null, $interactive = true)
{
Expand Down
2 changes: 1 addition & 1 deletion Tests/Helper/QuestionHelperTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
/**
* @group tty
*/
class QuestionHelperTest extends AbstractQuestionHelperTest
class QuestionHelperTest extends AbstractQuestionHelperTestCase
{
public function testAskChoice()
{
Expand Down
2 changes: 1 addition & 1 deletion Tests/Helper/SymfonyQuestionHelperTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
/**
* @group tty
*/
class SymfonyQuestionHelperTest extends AbstractQuestionHelperTest
class SymfonyQuestionHelperTest extends AbstractQuestionHelperTestCase
{
public function testAskChoice()
{
Expand Down

0 comments on commit 4b81c20

Please sign in to comment.