Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise TypeError for bool(Booleans) except true, false #401

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Raise TypeError for bool(Booleans) except true, false #401

merged 3 commits into from
Apr 20, 2022

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Apr 18, 2022

No description provided.

@isuruf isuruf requested a review from a team April 19, 2022 23:08
bjodah
bjodah approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@bjodah bjodah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. So we had an incorrect test hiding in test_eval_double2() then I suppose?

@isuruf
Copy link
Member Author

isuruf commented Apr 20, 2022

So we had an incorrect test hiding in test_eval_double2() then I suppose?

Yes, assert lhs < rhs is true regardless of lhs and rhs because bool(Lt(lhs, rhs)) silently produces true.

rikardn
rikardn approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@rikardn rikardn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isuruf isuruf merged commit 3528389 into symengine:master Apr 20, 2022
@isuruf
Copy link
Member Author

isuruf commented Apr 20, 2022

Thanks for the review

@isuruf isuruf deleted the bool branch April 20, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikardn rikardn rikardn approved these changes

@bjodah bjodah bjodah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isuruf @bjodah @rikardn