-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Call Score and Insights Features to Go SDK #100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aksharesh-symbl
approved these changes
Sep 21, 2023
* GetCallScoreStatusById * GetInsightStatusById * GetCallScore
* GetInsightsListUiUrl *GetInsightsDetailsUiURI
i believe the sentiment field should be removed on the AsyncURLFileRequest (possibly others) when trying to set it to true i get a error back from your api |
sini-sk
approved these changes
Sep 22, 2023
…o experience ui methods * Adding example tests for new methods
aksharesh-symbl
approved these changes
Sep 22, 2023
moona3k
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
This PR introduces new capabilities to the Go SDK, allowing users to access call score and insights-related features.
New Methods Introduced:
GetCallScoreStatusById
GetInsightStatusById
GetCallScore
GetInsightsListUiURI
GetInsightsDetailsUiURI
Updates:
AsyncURLFileRequest
struct to support the new features.What this PR does / why we need it
With the introduction of call score and insights UI features in our platform, it's imperative to ensure that our Go SDK is equipped to support these functionalities. This PR ensures that developers can seamlessly integrate and leverage these new features via the SDK, enhancing the overall developer experience.
Which issue(s) this PR fixes
This PR addresses and resolves issue: SODW 657.
Describe testing done for PR
To ensure the robustness and reliability of the new features:
AsyncURLFileRequest
struct.Special notes for your reviewer
As we roll out these new features, it's essential to maintain the integrity and reliability of the SDK. I'd appreciate a thorough review of the new properties' implementation, especially any validation logic. Ensuring that the SDK remains robust and error-free is paramount as developers begin to utilize these new functionalities.