Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Call Score and Insights Features to Go SDK #100

Merged
merged 10 commits into from
Sep 25, 2023

Conversation

subodhjenasymbl
Copy link
Contributor

@subodhjenasymbl subodhjenasymbl commented Sep 21, 2023

Details:

This PR introduces new capabilities to the Go SDK, allowing users to access call score and insights-related features.

New Methods Introduced:

  • GetCallScoreStatusById
  • GetInsightStatusById
  • GetCallScore
  • GetInsightsListUiURI
  • GetInsightsDetailsUiURI

Updates:

  • Enhanced the AsyncURLFileRequest struct to support the new features.
  • Updated request and response types associated with the new methods.
  • Provided examples on how to utilize the new features.

What this PR does / why we need it

With the introduction of call score and insights UI features in our platform, it's imperative to ensure that our Go SDK is equipped to support these functionalities. This PR ensures that developers can seamlessly integrate and leverage these new features via the SDK, enhancing the overall developer experience.

Which issue(s) this PR fixes

This PR addresses and resolves issue: SODW 657.

Describe testing done for PR

To ensure the robustness and reliability of the new features:

  • Unit tests were added to validate the correct implementation and behavior of the new properties in the AsyncURLFileRequest struct.
  • The SDK was integrated into a sample application, where the call score and insights UI features were tested, confirming their proper functioning.

Special notes for your reviewer

As we roll out these new features, it's essential to maintain the integrity and reliability of the SDK. I'd appreciate a thorough review of the new properties' implementation, especially any validation logic. Ensuring that the SDK remains robust and error-free is paramount as developers begin to utilize these new functionalities.

@subodhjenasymbl subodhjenasymbl added the enhancement New feature or request label Sep 21, 2023
@subodhjenasymbl subodhjenasymbl changed the title Adds properties needed for call score to async file upload apis Adding Call Score Support to GoSDK Sep 21, 2023
@subodhjenasymbl subodhjenasymbl changed the title Adding Call Score Support to GoSDK Adding Call Score Support to Go SDK Sep 21, 2023
@subodhjenasymbl subodhjenasymbl changed the title Adding Call Score Support to Go SDK Adding Call Score & Insights Ui Support to Go SDK Sep 21, 2023
* GetCallScoreStatusById
* GetInsightStatusById
* GetCallScore
* GetInsightsListUiUrl
*GetInsightsDetailsUiURI
@subodhjenasymbl subodhjenasymbl changed the title Adding Call Score & Insights Ui Support to Go SDK Add Call Score and Insights Features to Go SDK Sep 21, 2023
@bcorrigeux
Copy link

i believe the sentiment field should be removed on the AsyncURLFileRequest (possibly others) when trying to set it to true i get a error back from your api

…o experience ui methods

* Adding example tests for new methods
@subodhjenasymbl subodhjenasymbl requested review from sini-sk, moona3k and bwaval and removed request for aksharesh-symbl, sini-sk, moona3k and bwaval September 22, 2023 10:37
@subodhjenasymbl subodhjenasymbl requested review from moona3k and removed request for moona3k September 22, 2023 12:32
@subodhjenasymbl subodhjenasymbl merged commit ec07b9e into main Sep 25, 2023
@subodhjenasymbl subodhjenasymbl deleted the feature/call-score branch September 25, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants