Skip to content

Commit

Permalink
update todo and delete finished items
Browse files Browse the repository at this point in the history
  • Loading branch information
rebeccamccabe committed May 21, 2024
1 parent 3a93eb4 commit 0a9acce
Showing 1 changed file with 5 additions and 8 deletions.
13 changes: 5 additions & 8 deletions dev/MEEM/test_MEEM.m
Original file line number Diff line number Diff line change
@@ -1,18 +1,15 @@
% todo:

Check failure on line 1 in dev/MEEM/test_MEEM.m

View workflow job for this annotation

GitHub Actions / JUnit Test Report

test_MEEM.run

Error occurred in test_MEEM/run and it did not run to completion. ---------
Raw output
Error occurred in test_MEEM/run and it did not run to completion.
    ---------
    Error ID:
    ---------
    'MATLAB:UndefinedFunction'
    --------------
    Error Details:
    --------------
    Unrecognized function or variable 'heaving_IC'.
    
    Error in test_MEEM (line 52)
    [mu_nondim, lambda_nondim] = run_MEEM(heaving_IC, heaving_OC, auto_BCs, N_num, M_num, K_num, ...

Check failure on line 1 in dev/MEEM/test_MEEM.m

View workflow job for this annotation

GitHub Actions / JUnit Test Report

test_MEEM.plotHydroCoeffsVsWavenumber

Error occurred in test_MEEM/plotHydroCoeffsVsWavenumber and it did not run to completion. ---------
Raw output
Error occurred in test_MEEM/plotHydroCoeffsVsWavenumber and it did not run to completion.
    ---------
    Error ID:
    ---------
    'MATLAB:UndefinedFunction'
    --------------
    Error Details:
    --------------
    Unrecognized function or variable 'm0_nums'.
    
    Error in test_MEEM (line 59)
    plot(m0_nums,mu_nondim, m0_nums,lambda_nondim)
% - get actual hydro coeffs (check)
% - loop to get coeffs as a function of frequency (check)
% - write symbolic to file so it runs the solve fast (check)
% - check that the same dimensions scaled by some constant give the same
% nondim hydro coeffs (checked, doesn't match, must resolve)
% - do convergence study on hydro coeff vs N (check)
% - compare hydro coeffs against Yeung (check) and WAMIT (unofficially
% - compare hydro coeffs against WAMIT (unofficially
% checked, A is ~2x too big and B is reasonable)
% - get excitation force
% - do convergence study on matching quality vs N
% - integrate into mdocean (check)
% - only run for every freq not wave height
% - make validation an official part of the testcases

% extensions for later:
% - time profiling and speedup (check)
% - do convergence study on matching quality vs N
% - more speedup
% - h = 1 gives divide by zero error, investigate
% - update auto BCs to work with different N,M,K
% - find the difference between auto BCs and regular BCs
Expand Down

0 comments on commit 0a9acce

Please sign in to comment.