Merge pull request #36 from symbiotejs/fix-prop-binding-race

fix: *prop binding race
symbiotejs · Jul 8, 2022 · 54609cf · 54609cf
2 parents f9c6350 + abccd2d
commit 54609cf
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/core/BaseComponent.js b/core/BaseComponent.js
@@ -187,7 +187,15 @@ export class BaseComponent extends HTMLElement {
    */
   sub(prop, handler) {
     let parsed = BaseComponent.__parseProp(/** @type {string} */ (prop), this);
-    this.allSubs.add(parsed.ctx.sub(parsed.name, handler));
+    // @ts-ignore
+    if (!parsed.ctx.has(prop)) {
+      // Avoid *prop binding race:
+      window.setTimeout(() => {
+        this.allSubs.add(parsed.ctx.sub(parsed.name, handler));
+      });
+    } else {
+      this.allSubs.add(parsed.ctx.sub(parsed.name, handler));
+    }
   }
 
   /** @param {String} prop */

diff --git a/package.json b/package.json
@@ -25,7 +25,7 @@
   "publishConfig": {
     "access": "public"
   },
-  "version": "1.8.6",
+  "version": "1.8.7",
   "description": "Symbiote.js",
   "author": "[email protected]",
   "license": "MIT",