DEP Upgrade frontend build stack #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Jan 25, 2023
Comment on lines
-83
to
-85
| if (Controller::curr() instanceof ContentController) { | ||
| Requirements::javascript('silverstripe/admin: thirdparty/jquery/jquery.js'); | ||
| } |
There was a problem hiding this comment.
That's not stored there anymore - and even if it was, we shouldn't just inject jQuery into peoples' projects like this
GuySartorelli
force-pushed
the
pulls/6/frontend-build-stack
branch
from
d8f7d40 to
bd51378
Compare
GuySartorelli
commented
Jan 25, 2023
| @@ -1 +0,0 @@ | |||
| 2.0.0 | |||
There was a problem hiding this comment.
This file isn't used anywhere and it just going to stay outdated if we don't remove it
GuySartorelli
force-pushed
the
pulls/6/frontend-build-stack
branch
from
bd51378 to
c408300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See silverstripe/silverstripe-admin#1389 for a wider discussion on most of the changes
Parent issue