Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes GridFieldEditableColumns::isChanged method for non-string values (e.g. arrays for has_many / many_many relations) #343

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

bumbus
Copy link
Contributor

@bumbus bumbus commented Jun 29, 2022

This problem seems to emerge since SilverStripe 4.11.

Bumbus added 2 commits June 29, 2022 10:16
Copy link
Collaborator

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works locally.
Thank you for this.

@GuySartorelli GuySartorelli merged commit f56bf67 into symbiote:3.4 Aug 1, 2022
@GuySartorelli
Copy link
Collaborator

Released as 3.4.2

@bumbus bumbus deleted the 3.4 branch November 29, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants