Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't reorder many many versioned classes #250

Merged
merged 1 commit into from
Mar 6, 2018
Merged

Can't reorder many many versioned classes #250

merged 1 commit into from
Mar 6, 2018

Conversation

deracs
Copy link

@deracs deracs commented Mar 6, 2018

Currently when updating a list of a many many versioned items the handleReorder method was going through the ORM process. Previously it had a $isVersioned = false variable set that would allow for this to go through the non ORM way.

I've reverted back to how it previously was to fix this issue

@robbieaverill
Copy link
Contributor

I think I'm OK with this change, seeing as #243 originally had this logic, and the merge up of #233 is what I think caused this regression.

@robbieaverill robbieaverill merged commit b93a8f2 into symbiote:master Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants