Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT ESLint issues #497

Merged

Conversation

sabina-talipova
Copy link
Collaborator

Description

Turn on some of the ESLint.

Parent issue

@sabina-talipova sabina-talipova changed the base branch from 5 to 6 July 5, 2023 02:53
@sabina-talipova sabina-talipova changed the title Pulls/6/turn on eslint rules FIX ESLint issues Jul 5, 2023
@sabina-talipova
Copy link
Collaborator Author

Failed Behat tests are unrelated to changes that has been done.

Copy link
Collaborator

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit and PR prefix from FIX to MNT

@sabina-talipova sabina-talipova force-pushed the pulls/6/turn-on-eslint-rules branch from 2611282 to f31394c Compare July 7, 2023 04:04
@sabina-talipova sabina-talipova changed the title FIX ESLint issues MNT ESLint issues Jul 7, 2023
@emteknetnz emteknetnz merged commit 65a9c7f into symbiote:6 Jul 9, 2023
@emteknetnz emteknetnz deleted the pulls/6/turn-on-eslint-rules branch July 9, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants