Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX CSS and JS warnings #482

Conversation

sabina-talipova
Copy link
Collaborator

Description

  • Suppressed eslint and sass-lint warnings
  • Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.
    • Replaced divider / to calc(*/*) function

Parent issue

Copy link
Collaborator

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some minor suggestion, but I'm not overly fuss about those.

client/src/styles/WorkflowField.scss Outdated Show resolved Hide resolved
client/src/styles/AdvancedWorkflowAdmin.scss Show resolved Hide resolved
@sabina-talipova sabina-talipova force-pushed the pulls/6.0/fix-frontend-warnings branch from 6741dff to 95470de Compare March 21, 2023 23:15
@sabina-talipova sabina-talipova force-pushed the pulls/6.0/fix-frontend-warnings branch from 95470de to a9f1f6c Compare March 21, 2023 23:29
@maxime-rainville maxime-rainville merged commit 5245d2e into symbiote:6.0 Mar 24, 2023
@maxime-rainville maxime-rainville deleted the pulls/6.0/fix-frontend-warnings branch March 24, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants