Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Helpers.cpp #37

Closed
wants to merge 4 commits into from
Closed

Update Helpers.cpp #37

wants to merge 4 commits into from

Conversation

vvyoko
Copy link

@vvyoko vvyoko commented Feb 10, 2022

fFix image size display

@sylikc
Copy link
Owner

sylikc commented Feb 10, 2022

Interesting feature... I'll look at it. Maybe make it an option.

I actually myself very much like the feature where it goes into an error lol... so that I know if i accidentally deleted a file that I didn't mean to delete... but updating the file list seems like a more user friendly way to handle the problem

@sylikc sylikc added the enhancement New feature or request label Feb 10, 2022
@vvyoko
Copy link
Author

vvyoko commented Feb 11, 2022

Interesting feature... I'll look at it. Maybe make it an option.

I actually myself very much like the feature where it goes into an error lol... so that I know if i accidentally deleted a file that I didn't mean to delete... but updating the file list seems like a more user friendly way to handle the problem

Other software with similar features use a similar processing method

There is no need for the image viewer to prompt other software to delete files?
This should be the job of the security software
The image viewer should just deal with itself when this happens

Even if it monitors deleted files by mistake, it only monitors the current file...
Deleting other images in the same folder also uses the update list (which is automatically skipped when browsing to a file)
without indicating that the file has been deleted

@sylikc
Copy link
Owner

sylikc commented Feb 12, 2022

what happened to this commit?

@vvyoko
Copy link
Author

vvyoko commented Feb 12, 2022

Sorry
I used this action to pull the update
https://github.com/apps/pull

I didn't notice that it would affect the pull that was already submitted
I'll try again by unusing and reworking

Fix file size self-fitting display
Add a condition to monitor that other programs delete the current file for updating the list and jump to the next one
updated zh_cn translation
@sylikc
Copy link
Owner

sylikc commented Feb 12, 2022

Sorry I used this action to pull the update https://github.com/apps/pull

I didn't notice that it would affect the pull that was already submitted I'll try again by unusing and reworking

I just read the comment of the pull app, it does a hard reset on master... so if you're going to use the pull app, work on a branch 😅

@sylikc
Copy link
Owner

sylikc commented Mar 2, 2022

I'm going to try to see if I can add an option for this and get to have it both ways by changing the INI file only

@sylikc
Copy link
Owner

sylikc commented Apr 1, 2022

I'm still looking into this, in terms of adding an option so it can have it both ways...

I actually saw the specific feature that like allowed pictures to continue to be displayed after deleting (or at least doesn't lock the file, and allows removal while viewed) https://github.com/sylikc/jpegview/blob/master/CHANGELOG.txt#L264

But I'm also working on an INI file revamp, so if this eventually goes in, it has to wait on the INI revamp. Still, I appreciate the contribution. I'll get to merging it when I can get through the INI layering...

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants