feat: run action for OCI bundle #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrudg
force-pushed
the
oci-actions
branch
11 times, most recently
from
dd91282 to
66bebdb
Compare
As a first step toward run/shell/exec actions on native OCI images, implement a minimal `singularity run --oci mybundle` which: * Requires an on-disk bundle with appropriate `config.json`. * Runs this bundle using `crun` or `runc`. * Makes no attempt to handle any arguments or options. * Does not modify the `config.json` - i.e. it must match namespace / mapping requirements for rootless execution etc. At this stage, the functionality is essentially equivalent to `singularity oci run` and is not yet useful. The primary purpose of the PR is to refactor some of the code that passes args for launching a container. In addition, we now use `crun` in preference to `runc` if available. `crun` supports e.g. single uid->uid mapping in a usernamespace (without root mapping). Closes sylabs#598
Add subtest information to the large multi-step OCI test functions for easier debugging. Move the test of `oci help` out of the SEQ/ordered section. It can run in parallel, and only once regardless of cgroups managers available.
The Ubuntu packaged crun is very old. Use a release from GitHub instead.
tri-adam
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Pull Request (PR):
As a first step toward run/shell/exec actions on native OCI images, implement a minimal
singularity run --oci mybundlewhich:config.json.crunorrunc.config.json- i.e. it must match namespace / mapping requirements for rootless execution etc.At this stage, the functionality is essentially equivalent to
singularity oci runand is not yet useful.The primary purpose of the PR is to refactor some of the code that passes args for launching a container.
In addition, we now use
crunin preference toruncif available.crunsupports e.g. single uid->uid mapping in a usernamespace (without root mapping).This fixes or addresses the following GitHub issues:
Before submitting a PR, make sure you have done the following:
make checkand tested this PR locally with amake test, andmake testallif possible (see CONTRIBUTING.md).