Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm-projectile-grep fails to respect projectile-use-git-grep variable #1835

Closed
tko opened this issue Jun 3, 2015 · 4 comments
Closed

helm-projectile-grep fails to respect projectile-use-git-grep variable #1835

tko opened this issue Jun 3, 2015 · 4 comments

Comments

@tko
Copy link
Contributor

tko commented Jun 3, 2015

In a git project setting projectile-use-git-grep significantly increases the performance of projectile-grep but that does not seem to have any effect on helm-projectile-grep. This is rather unfortunate as while the latter has reasonable SPC p s g keyboard shortcut assigned the former does not making it relatively inconvenient to use.

@syl20bnr
Copy link
Owner

syl20bnr commented Jun 5, 2015

I wonder if this is something to handle in spacemacs or upstream in helm-projectile (I think it comes from the projectile repo).

@tko
Copy link
Contributor Author

tko commented Jun 5, 2015

Comparing https://github.com/bbatsov/projectile/blob/master/projectile.el#L1700 and https://github.com/bbatsov/projectile/blob/master/helm-projectile.el#L630 it looks like an upstream issue; helm-projectile only supports ack and "grep -r" currently.

@syl20bnr
Copy link
Owner

syl20bnr commented Jun 5, 2015

Can you report this upstream and link to the issue here so we can track its status ?

@StreakyCobra
Copy link
Contributor

It looks like the issue has been fixed upstream. If it is not the case, feel free to ping me here, I'll reopen it ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants