Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm-projectile-grep fails to respect projectile-use-git-grep variable #763

Closed
tko opened this issue Jun 5, 2015 · 1 comment · Fixed by #864
Closed

helm-projectile-grep fails to respect projectile-use-git-grep variable #763

tko opened this issue Jun 5, 2015 · 1 comment · Fixed by #864

Comments

@tko
Copy link

tko commented Jun 5, 2015

In a git project setting projectile-use-git-grep significantly increases the performance of projectile-grep but that does not seem to have any effect on helm-projectile-grep.

From: syl20bnr/spacemacs#1835

@bbatsov bbatsov added the helm label Jul 11, 2015
@yatesco
Copy link

yatesco commented Sep 11, 2015

I can confirm the same.

I have (setq projectile-use-git-grep 1) in my .emacs.d/personal/personal.el yet when I do C-c p s g it is showing me results from files that are ignored in my .gitignore. If I manually call vc-git-grep for * files and navigate to my project root then I only see results in non-ignored files.

In addition, helm-git-grep works as expected.

(Thanks for projectile and prelude though - they are brill!, little issues like this not-withstanding ;-)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants