Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: permissionless token addition with GMP #261

Merged
merged 15 commits into from
Aug 20, 2024

Conversation

nmlinaric
Copy link
Contributor

Description

Adds permissionless token addition using XERC20 and GMP.

Related Issue Or Context

Closes: #257

How Has This Been Tested? Testing details.

unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

contracts/XERC20/XERC20.sol Show resolved Hide resolved
contracts/adapters/GmpTransferAdapter.sol Show resolved Hide resolved
contracts/adapters/GmpTransferAdapter.sol Show resolved Hide resolved
contracts/adapters/GmpTransferAdapter.sol Show resolved Hide resolved
@nmlinaric nmlinaric requested a review from mpetrun5 August 1, 2024 11:26
@nmlinaric nmlinaric force-pushed the nmlinaric/permissionless-token-adapter branch from 9f0e79b to 632a273 Compare August 4, 2024 10:42
@nmlinaric nmlinaric force-pushed the nmlinaric/permissionless-token-adapter branch from 6de3b7d to 3a943d3 Compare August 4, 2024 12:05
@nmlinaric nmlinaric force-pushed the nmlinaric/permissionless-token-adapter branch from 726733b to 68ef0be Compare August 5, 2024 19:30
@nmlinaric nmlinaric force-pushed the nmlinaric/permissionless-token-adapter branch from 68ef0be to 319e46e Compare August 5, 2024 19:44
contracts/adapters/GmpTransferAdapter.sol Outdated Show resolved Hide resolved
contracts/adapters/GmpTransferAdapter.sol Outdated Show resolved Hide resolved
test/gmpTransferAdapter/erc20Transfer/executeProposal.js Outdated Show resolved Hide resolved
contracts/adapters/GmpTransferAdapter.sol Outdated Show resolved Hide resolved
test/gmpTransferAdapter/nativeTransfer/deposit.js Outdated Show resolved Hide resolved
@nmlinaric nmlinaric force-pushed the nmlinaric/permissionless-token-adapter branch 3 times, most recently from 092f90e to 2dd8d00 Compare August 7, 2024 14:51
@nmlinaric nmlinaric force-pushed the nmlinaric/permissionless-token-adapter branch from 2dd8d00 to 1f8c901 Compare August 7, 2024 14:54
@nmlinaric nmlinaric force-pushed the nmlinaric/permissionless-token-adapter branch from 1f8c901 to 206f762 Compare August 7, 2024 14:55
@nmlinaric nmlinaric requested a review from lastperson August 8, 2024 07:53
@nmlinaric nmlinaric force-pushed the nmlinaric/permissionless-token-adapter branch from a126a7b to 0bf75c6 Compare August 8, 2024 19:21
contracts/adapters/GmpTransferAdapter.sol Outdated Show resolved Hide resolved
contracts/adapters/GmpTransferAdapter.sol Outdated Show resolved Hide resolved
contracts/adapters/GmpTransferAdapter.sol Outdated Show resolved Hide resolved
@nmlinaric nmlinaric requested a review from lastperson August 18, 2024 13:24
@nmlinaric nmlinaric merged commit 0234458 into master Aug 20, 2024
6 checks passed
@nmlinaric nmlinaric deleted the nmlinaric/permissionless-token-adapter branch August 20, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permissionless token adapter
3 participants