-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Modified Dynamic Fee Handlers with twap oracle #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viatrix
requested changes
Apr 19, 2024
viatrix
approved these changes
Apr 19, 2024
viatrix
approved these changes
Apr 22, 2024
lastperson
requested changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to account for possibility where there is no destination domain wrap pool available. In such case it should be possible to manually set the price rate.
viatrix
approved these changes
Apr 26, 2024
lastperson
approved these changes
Apr 29, 2024
andersonlee725
changed the title
Modified Dynamic Fee Handlers with twap oracle
feat: Modified Dynamic Fee Handlers with twap oracle
Apr 29, 2024
nmlinaric
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified Dynamic Fee Handlers calculate the fee in the native coin based on the twap oracle.
Description
Created a twap oracle using Uniswap V3.
In the Dynamic Fee Handlers, calculate the tx cost fee of the destination chain and the fee is converted to the amount in the native coin of the resource chain.
For converting, the twap oracle is used.
Related Issue Or Context
Closes: #
How Has This Been Tested? Testing details.
Types of changes
Checklist: