fix: optionalMessage and optionalGas encoding
#536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wainola
reviewed
Sep 12, 2024
wainola
approved these changes
Sep 12, 2024
|
Tested on PR - > deposits with value "0" for optionalGas now is encoded correct |
saadahmsiddiqui
pushed a commit
that referenced
this pull request
Sep 12, 2024
🤖 I have created a release *beep* *boop* --- ## [1.3.1](evm-v1.3.0...evm-v1.3.1) (2024-09-12) ### Bug Fixes * `optionalMessage` and `optionalGas` encoding ([#536](#536)) ([ebc8885](ebc8885)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
optionalGaswhen set to 0 is not encoded by evm SDK. This PR fixes the encoding issueRelated Issue Or Context
#535
Closes: #535
How Has This Been Tested? Testing details.
Types of changes
Checklist: