Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: import for utils on core package #520

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix: import for utils on core package #520

merged 1 commit into from
Sep 10, 2024

Conversation

wainola
Copy link
Contributor

@wainola wainola commented Sep 10, 2024

Description

Currently if we want to use some of the utils helpers functions from the core package, calling them will trigger import errors from multicall.js file

Related Issue Or Context

Closes: #

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@saadahmsiddiqui saadahmsiddiqui merged commit f718e74 into main Sep 10, 2024
3 checks passed
@saadahmsiddiqui saadahmsiddiqui deleted the fix/core-utils-import branch September 10, 2024 08:51
@MakMuftic MakMuftic mentioned this pull request Sep 10, 2024
Merged
saadahmsiddiqui pushed a commit that referenced this pull request Sep 10, 2024
@MakMuftic
chore(main): release core 1.2.1 (#523)
90c75be 
🤖 I have created a release *beep* *boop*
---


##
[1.2.1](core-v1.2.0...core-v1.2.1)
(2024-09-10)


### Bug Fixes

* import for utils on core package
([#520](#520))
([f718e74](f718e74))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saadahmsiddiqui saadahmsiddiqui saadahmsiddiqui approved these changes

@Lykhoyda Lykhoyda Awaiting requested review from Lykhoyda

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wainola @saadahmsiddiqui