Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type-checking and IDE completions for HTML tags #354

Merged
merged 3 commits into from
Feb 9, 2022
Merged

Conversation

lukechu10
Copy link
Member

Fixes #327

@lukechu10 lukechu10 added A-macro Area: macros A-ergonomics Area: API ergonomics labels Feb 9, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #354 (e0a7a9c) into master (923c23c) will increase coverage by 0.03%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
+ Coverage   66.05%   66.08%   +0.03%     
==========================================
  Files          48       48              
  Lines        7294     7304      +10     
==========================================
+ Hits         4818     4827       +9     
- Misses       2476     2477       +1     
Impacted Files Coverage Δ
packages/sycamore/src/lib.rs 100.00% <ø> (ø)
packages/sycamore/src/suspense.rs 90.51% <50.00%> (-0.67%) ⬇️
packages/sycamore-macro/src/view/codegen.rs 95.90% <100.00%> (+0.06%) ⬆️
packages/sycamore/src/component.rs 66.66% <100.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 923c23c...e0a7a9c. Read the comment docs.

@lukechu10 lukechu10 merged commit 8fb20c6 into master Feb 9, 2022
@lukechu10 lukechu10 deleted the html-intellisense branch February 9, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ergonomics Area: API ergonomics A-macro Area: macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile-time checked element names
2 participants