Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

basic test for alterTable #18

Merged
merged 2 commits into from
May 5, 2018
Merged

basic test for alterTable #18

merged 2 commits into from
May 5, 2018

Conversation

DeanChensj
Copy link
Collaborator

Basic test for add / drop / alter type, will add more test later

@DeanChensj DeanChensj requested review from Dingshilun and sxzh93 May 4, 2018 15:36
Dingshilun
Dingshilun approved these changes May 5, 2018
View reviewed changes
Copy link
Collaborator

@Dingshilun Dingshilun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sxzh93
sxzh93 approved these changes May 5, 2018
View reviewed changes
Copy link
Owner

@sxzh93 sxzh93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DeanChensj DeanChensj merged commit 32a260f into master May 5, 2018
@DeanChensj DeanChensj deleted the alter_test branch May 5, 2018 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dingshilun Dingshilun Dingshilun approved these changes

@sxzh93 sxzh93 sxzh93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DeanChensj @Dingshilun @sxzh93