Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transformation to tortoise radius #6393

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Dec 2, 2024

Proposed changes

Bundles some root-finding code from https://github.com/tosburn3/KerrGeodesicsC to transform between Boyer-Lindquist and tortoise radius. The bundled code has figured out good initial guesses and a robust method for the root find.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu requested a review from wthrowe December 2, 2024 21:27
@wthrowe
Copy link
Member

wthrowe commented Dec 3, 2024

I think this is a license violation. The GPL would let us distribute a verbatim copy of the upstream package, but I don't think we can distribute a version that has been modified like this as part of SpECTRE.

@nilsvu
Copy link
Member Author

nilsvu commented Dec 4, 2024

My understanding is that this is a redistribution of the GPL-licensed code with some changes still under the GPL license, which is ok. The changes are: Deleted some functions to avoid dependence on FFTW, added a CMakeLists.txt to compile the code with CMake, added a C++ compatibility header, and auto-formatted the code. These are listed in the README, and the license is also included.

Code from https://github.com/tosburn3/KerrGeodesicsC
that computes tortoise coordinates and has figured out
good initial guesses and a robust solver.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants