Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the GaugePlaneWave implementations for SO-CCZ4 in development. #6386

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

hen-w
Copy link

@hen-w hen-w commented Nov 26, 2024

Proposed changes

Change the GaugePlaneWave implementations for SO-CCZ4 in development. The struct IntermediateVars is moved to public so one can easily construct the h function and its derivatives.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@hen-w hen-w requested a review from nilsdeppe November 26, 2024 18:09
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small request. You can squash immediately.

Comment on lines +27 to +29
const std::unique_ptr<MathFunction<1, Frame::Inertial>>& profile)
: wave_vector_(wave_vector),
profile_(profile->get_clone()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the move is better for the unique ptr. For the array it doesn't matter. It's possible to elide a copy by taking the pointer by value and then moving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants