Use new common time dependent options in Sphere and BCO domains #6115
+295
−397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Final PR in the series that revamps the time dependent options for the Sphere and BCO domains.
This actually adds all the new common options to the domain creators.
Fixes #5584.
Upgrade instructions
The options for the Rotation and Expansion map have changed. They are now
For any of the time dependent map options, you can choose the function of time from a volume file by specifying the following options (not just for Expansion, but for Rotation, Translation, and Shape as well)
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments
Depends on and includes #6109, #6113, and #6114.