Fixed string case

“X-Forecast-API-Calls” and “X-Response-Time” are now lowercase from DarkSky.net. Updated source and unit tests for this interface change. GitHub Issue #54.
sxg · Oct 2, 2018 · b00250b · b00250b
1 parent 3492bdc
commit b00250b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Source/RequestMetadata.swift b/Source/RequestMetadata.swift
@@ -27,12 +27,12 @@ public struct RequestMetadata {
     /// - returns: A new `RequestMetadata` filled with data from the given Dark Sky API response header fields `Dictionary`.
     public init(fromHTTPHeaderFields headerFields: [AnyHashable: Any]) {
         cacheControl = headerFields["Cache-Control"] as? String
-        if let forecastAPICallsHeader = headerFields["X-Forecast-API-Calls"] as? String {
+        if let forecastAPICallsHeader = headerFields["x-forecast-api-calls"] as? String {
             apiRequestsCount = Int(forecastAPICallsHeader)
         } else {
             apiRequestsCount = nil
         }
-        if var responseTimeHeader = headerFields["X-Response-Time"] as? String {
+        if var responseTimeHeader = headerFields["x-response-time"] as? String {
             // Remove "ms" units from the string
             responseTimeHeader = responseTimeHeader.trimmingCharacters(in: CharacterSet.letters)
             responseTime = Float(responseTimeHeader)

diff --git a/Tests/RequestMetadataTests.swift b/Tests/RequestMetadataTests.swift
@@ -13,7 +13,7 @@ class RequestMetadataTests: XCTestCase {
 
     func testInitFromHTTPHeaderFields() {
         //  Given
-        let httpHeaderFields = ["Cache-Control": "max-age=60", "X-Forecast-API-Calls": "12", "X-Response-Time": "123.45ms"]
+        let httpHeaderFields = ["Cache-Control": "max-age=60", "x-forecast-api-calls": "12", "x-response-time": "123.45ms"]
 
         //  When
         let requestMetadata = RequestMetadata(fromHTTPHeaderFields: httpHeaderFields)