-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot start with "ModuleNotFoundError" after installing with "pip install esbonio[lsp]" #147
Comments
Thank you for such a detailed issue report! I'm about to merge #148 which should result in esbonio v0.5.1 being released with this issue resolved. Feel free to re-open this issue if the problem persists. |
Since it was fixed in esbonio itself. REF: swyddfa/esbonio#147
A similar issue still persists with latest version of
Python:
Error:
But
The version of
|
It looks like |
`lsprotocol` uses the `import attrs` API which was only introduced in [`v21.3.0`](https://www.attrs.org/en/stable/changelog.html#id7) . This PR sets a minimum version for attrs in the python package's `pyproject.toml` to hopefully guard against issues [like this one](swyddfa/esbonio#147 (comment)) in the future. **Question:** Is it sufficient to rely on the version bound set here to ensure the correct version is also installed for `pygls` and `esbonio`? Or since both downstream packages also `import attrs` themselves, is it more correct to have a version bound set in both `pygls` and `esbonio`? :thinking:
That fixes it, thanks! |
Reproduction Procedure (prepare)
Error
It looks like "pygls" is "0.10.2"
Looking at this issue, it looks like 0.10.x is not yet supported. #144
You may need to adjust the package dependencies.
Misc
As a workaround, I set the pygls version to 0.9.x as shown below, and it started.
The text was updated successfully, but these errors were encountered: