Image: Revert generic image, fix width bug #121
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisUngemach
commented
Feb 27, 2025
DenisUngemach
commented
- it is not that easily possible to add a generic image concept to the existing image implementations. this must be done properly.
- SkiaImageDataProvider is ok.
- it is not that easily possible to add a generic image concept to the existing image implementations. this must be done properly. - SkiaImageDataProvider is ok. Signed-off-by: Denis Ungemach <[email protected]>
Merged
Signed-off-by: Denis Ungemach <[email protected]>
DenisUngemach
force-pushed
the
image_fixes
branch
from
ac8b6d7 to
080ebe8
Compare
Signed-off-by: Denis Ungemach <[email protected]>
DenisUngemach
force-pushed
the
image_fixes
branch
from
080ebe8 to
7ee03f8
Compare
|
It seems Drawing drawWithGC(Control control, GC originalGC, Consumer drawOperation) changes the alpha values in the image. This makes a proper image drawing much more difficult. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.