Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR
✨ 작업 내용
공유받은 문제집을 내부 문제 목록과 함께 저장하는 기능을 구현했습니다.
처음에 pathparam으로 구현했다가 uuid는 최대한 외부 노출을 피하는 편이 좋을 것 같아서(더하여 타인의 문제집 uuid이다보니) request body로 받는걸로 변경했습니다!
WorkbookService에서
getMember()
,getWorbook()
으로 extract했습니다.문제를 문제집에 추가하는 동작을
receiveSharedWorkbook
,addQuestionsToWorkbook
에서 모두 하므로,insertQuestion()
로 extract했습니다.✨ 참고 사항
⏰ 현재 버그
x
saveAll()
메서드 대신 배치 세이브 방식을 사용해서 성능을 개선해볼까합니다.✏ Git Close