nxlink: add option to override netloader target port #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional command line argument to override
NETLOADER_SERVER_PORTvia--port [port]or-z [port].Note:
-pis already used for path, so I arbitrarily chose-zas the single letter flag for port.Use-case: I have a remote server configured for Switch homebrew development which is used by multiple people. We use SSH tunnelling to forward the nxlink port to our Switch/emulator on local network, however only one person can do this at a time if we are limited to the default port. By allowing to override the port, we can choose any remote port for the SSH tunnel allowing multiple users to use nxlink simultaneously.
I know this use-case is niche considering there is no way to configure the netloader port in hbmenu by itself, so I understand if this PR is closed as out-of-scope.