hiddbg: modify hiddbgAttachHdlsWorkBuffer to accept a user-supplied buffer and size #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given that this command makes most sense to use in sysmodules (and I believe you are the only user), I think you can remove the old tmemCreate handling; leaving explicit memory management as the only option. |
|
There are definitely a few others using it who may be affected (sys-con and sys-botbase come to mind). I have no problem with removing the old handling though. Up to you guys. |
yellows8
reviewed
Feb 1, 2023
nx/include/switch/services/hiddbg.h
Outdated
| @@ -402,8 +402,10 @@ Result hiddbgUnsetAllAutoPilotVirtualPadState(void); | |||
| * @brief Initialize Hdls. | |||
| * @note Only available with [7.0.0+]. | |||
| * @param[out] session_id [13.0.0+] \ref HiddbgHdlsSessionId | |||
| * @param[in] buffer An existing buffer to be used as transfer memory. If null a new transfer memory will be created. | |||
There was a problem hiding this comment.
If null ... <- no longer applies
yellows8
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of
hiddbgAttachHdlsWorkBufferis incompatible with sysmodules using libstratosphere due to the libnx memory allocations intmemCreate. This modifies the existing function to create a transfer memory from an optional user-supplied buffer usingtmemCreateFromMemoryinstead.I wasn't sure whether breaking the existing API by adding the additional parameters was a good idea, but this seems like the most straightforward solution.