Feature/assets 387 umbau user UI uebersicht #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TIL-EBP
force-pushed
the
feature/assets-387-umbau-user-ui-uebersicht
branch
2 times, most recently
from
d297b73 to
774db20
Compare
daniel-va
requested changes
Feb 10, 2025
libs/client-shared/src/lib/components/filter-selector/filter-selector.component.ts
Outdated
Show resolved
Hide resolved
libs/client-shared/src/lib/components/filter-selector/filter-selector.component.ts
Outdated
Show resolved
Hide resolved
libs/client-shared/src/lib/components/search-input/search-input.component.html
Outdated
Show resolved
Hide resolved
libs/client-shared/src/lib/components/filter-selector/filter-selector.component.ts
Outdated
Show resolved
Hide resolved
libs/client-shared/src/lib/components/filter-selector/filter-selector.component.ts
Outdated
Show resolved
Hide resolved
daniel-va
requested changes
Feb 12, 2025
daniel-va
approved these changes
Feb 12, 2025
| @@ -85,18 +85,19 @@ export class UsersComponent implements OnInit, OnDestroy, AfterViewInit { | |||
| this.activeFilters$.next(activeFilters); | |||
| } | |||
|
|
|||
| private filterUsersBySearchTerm(user: User, searchTerm: string) { | |||
| private matchUsersBySearchTerm(user: User, searchTerm: string): boolean { | |||
| const searchTermLowerCase = searchTerm.toLowerCase(); | |||
| return Object.entries(user).some(([key, value]) => { | |||
| if (key === 'roles') { | |||
| return Array.from((value as Map<number, string>).keys()).some((id) => | |||
| this.workgroups.get(id)?.name.toLowerCase().includes(searchTerm.toLowerCase()) | |||
There was a problem hiding this comment.
Suggested change
| this.workgroups.get(id)?.name.toLowerCase().includes(searchTerm.toLowerCase()) | |
| this.workgroups.get(id)?.name.toLowerCase().includes(searchTermLowerCase) |
| @@ -85,18 +85,19 @@ export class UsersComponent implements OnInit, OnDestroy, AfterViewInit { | |||
| this.activeFilters$.next(activeFilters); | |||
| } | |||
|
|
|||
| private filterUsersBySearchTerm(user: User, searchTerm: string) { | |||
| private matchUsersBySearchTerm(user: User, searchTerm: string): boolean { | |||
| const searchTermLowerCase = searchTerm.toLowerCase(); | |||
There was a problem hiding this comment.
You could just reuse the same variable, but its up to you :)
Suggested change
| const searchTermLowerCase = searchTerm.toLowerCase(); | |
| searchTerm = searchTerm.toLowerCase(); |
TIL-EBP
force-pushed
the
feature/assets-387-umbau-user-ui-uebersicht
branch
from
9fbc0bc to
f9e085b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #387