-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(components): update back to top button to adapt to sticky header #4879
Open
myrta2302
wants to merge
17
commits into
main
Choose a base branch
from
4843-update-back-to-top-button-to-adapt-to-sticky-header-case
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+58
−13
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0af58b0
feat(components): update back to to button for sticky header case
myrta2302 e63a891
minor
myrta2302 adc9cdb
add changeset
myrta2302 0edb392
Merge branch 'main' into 4843-update-back-to-top-button-to-adapt-to-s…
myrta2302 a0277a4
incorporate elevation from token
myrta2302 acf8e6b
Merge branch '4843-update-back-to-top-button-to-adapt-to-sticky-heade…
myrta2302 4d6f967
minor changes
myrta2302 e2080b7
regex update
myrta2302 a9be603
minor changes
myrta2302 de693d9
lint error
myrta2302 1407f8c
Merge branch 'main' into 4843-update-back-to-top-button-to-adapt-to-s…
myrta2302 82f7eff
lint error
myrta2302 2ee522d
Merge branch '4843-update-back-to-top-button-to-adapt-to-sticky-heade…
myrta2302 6f49130
example correction
myrta2302 b88e3b4
update changeset
myrta2302 e9d9288
Merge branch 'main' into 4843-update-back-to-top-button-to-adapt-to-s…
myrta2302 68c7813
hide until post header gets hydrated
myrta2302 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
'@swisspost/design-system-documentation': patch | ||
'@swisspost/design-system-components': patch | ||
'@swisspost/design-system-styles': patch | ||
--- | ||
|
||
Adjusted the placement of the Back-to-top button to accommodate the sticky header. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it's because the previous swisspost-internet-header is not sticky, but on the preview, the back to top button is visible because it's not being hidden by the header. I think in all cases, it'd be best that the back to top button is not visible at all before we start scrolling.