Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(documentation): move internet-header, footer and breadcrumbs to raw-components and new header to modules #4258

Merged
merged 5 commits into from
Dec 13, 2024
Merged

fix(documentation): move internet-header, footer and breadcrumbs to raw-components and new header to modules #4258

merged 5 commits into from
Dec 13, 2024

Conversation

oliverschuerch
Copy link
Contributor

No description provided.

@oliverschuerch oliverschuerch requested review from a team as code owners December 13, 2024 13:27
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: aba6e3d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Dec 13, 2024 •
edited
Loading

Related Previews

alizedebray
alizedebray requested changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@alizedebray alizedebray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure the "Modules" section is initially collapsed?

packages/documentation/src/stories/modules/header/language-switch/language-switch.stories.ts Outdated Show resolved Hide resolved
packages/documentation/src/stories/modules/header/header.stories.ts Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@oliverschuerch oliverschuerch merged commit a3ce33d into main Dec 13, 2024
10 checks passed
@oliverschuerch oliverschuerch deleted the fix/documentation-header branch December 13, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alizedebray alizedebray alizedebray approved these changes

@gfellerph gfellerph gfellerph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliverschuerch @swisspost-bot @gfellerph @alizedebray