-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(documentation): add palette scss file import documentation #4127
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 691b91a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Related Previews |
@@ -25,3 +26,5 @@ You can apply this text color to any element by using the `.palette-text` class. | |||
<div className="hide-col-default"> | |||
<Controls of={paletteStories.Default} /> | |||
</div> | |||
|
|||
<StylesPackageImport components={['post-palettes']} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good if the import could adapt to the selected theme. It is stored in the local storage under swisspost-documentation-theme
, if not defined the default is "Post".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I use the value from the local storage, it doesn't update when I change the theme, so I had to update the styles package import from the styles switcher directly: https://github.com/swisspost/design-system/pull/4085/files#diff-7afcbc69ddf51598841204e61dceede5164073437393967b7e3b4c345515983b
It detects if there is a theme or a channel in the path of the scss and replaces it if needed to the correct theme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it also update post-palettes
for cargo-palettes
?
…hub.com/swisspost/design-system into 4025-add-style-imports-for-the-palettes
Quality Gate passedIssues Measures |
No description provided.