Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: intranet header condensed #4084

Open
wants to merge 12 commits into
base: release/v8
Choose a base branch
from
Open

feat: intranet header condensed #4084

wants to merge 12 commits into from

Conversation

gfellerph
Copy link
Member

@gfellerph gfellerph commented Nov 27, 2024 •
edited
Loading

This PR takes changes from #3539 and rebases them on the v8 branch which will also be the target branch for this change. It is meant as a replacement to #3539.

Co-authored-by: Pedroso Munoz Yohandris, IT10.3 extern [email protected]
Co-authored-by: Matthias Langhard [email protected]

@gfellerph gfellerph requested a review from a team as a code owner November 27, 2024 12:13
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: caed1ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Nov 27, 2024 •
edited
Loading

Related Previews

@socket-security Socket Security
Copy link

socket-security bot commented Nov 27, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/[email protected], npm/[email protected]

View full report↗︎

@gfellerph gfellerph added this to the Long Term Support milestone Nov 28, 2024
@alizedebray alizedebray requested review from oliverschuerch and removed request for alizedebray November 28, 2024 12:25
@oliverschuerch oliverschuerch force-pushed the intranet-header-condensed branch from 4799814 to 54eb1be Compare December 2, 2024 10:36
@oliverschuerch oliverschuerch requested review from alizedebray and removed request for oliverschuerch December 2, 2024 10:44
@gfellerph gfellerph mentioned this pull request Dec 2, 2024
Closed
oliverschuerch
oliverschuerch requested changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@oliverschuerch oliverschuerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a changeset!

packages/demo/src/app/intranet-layout/intranet-layout.component.html Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
10 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverschuerch oliverschuerch oliverschuerch approved these changes

@alizedebray alizedebray Awaiting requested review from alizedebray

Assignees
No one assigned
Labels
None yet
Projects
Design System Production Board
Status: 🤬 Dev in Code Review
Milestone
Long Term Support
Development

Successfully merging this pull request may close these issues.
3 participants
@gfellerph @swisspost-bot @oliverschuerch