Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): prevent postChange event emitting before post-tabs loads #3247

Merged
merged 3 commits into from
Jul 18, 2024
Merged

fix(components): prevent postChange event emitting before post-tabs loads #3247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96932b3
fix(components): prevent postChange event emitting before post-tabs l…
alizedebray Jul 10, 2024
28812bf
Merge branch 'main' into 2872-prevent-post-tabs-from-firing-a-change-…
alizedebray Jul 15, 2024
469230d
Merge branch 'main' into 2872-prevent-post-tabs-from-firing-a-change-…
alizedebray Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fifty-peaches-turn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@swisspost/design-system-components': patch
---

Prevent the `post-tabs` component from triggering a `post Change` event before it is loaded.
14 changes: 4 additions & 10 deletions packages/components/src/components/post-tabs/post-tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,23 +74,17 @@ export class PostTabs {
}

// hide the currently visible panel only if no other animation is running
if (previousTab && !this.showing && !this.hiding) {
this.hidePanel(previousTab.panel);
}
if (previousTab && !this.showing && !this.hiding) this.hidePanel(previousTab.panel);

// wait for any hiding animation to complete before showing the selected tab
if (this.hiding) {
await this.hiding.finished;
}
if (this.hiding) await this.hiding.finished;

this.showSelectedPanel();

// wait for any display animation to complete for the returned promise to fully resolve
if (this.showing) {
await this.showing.finished;
}
if (this.showing) await this.showing.finished;

this.postChange.emit(this.activeTab.panel);
if (this.isLoaded) this.postChange.emit(this.activeTab.panel);
}

private moveMisplacedTabs() {
Expand Down