Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): PoC for post-tabs using light dom (and slot emulation from stencil) #2776

Closed
wants to merge 2 commits into from

Conversation

imagoiq
Copy link
Contributor

@imagoiq imagoiq commented Mar 11, 2024

Currently, we are waiting on ionic-team/stencil#5403 (see, ionic-team/stencil#5335 (comment)). <post-tab-panel> are added to the first slot available (the one in <post-tab-header>) which is not the slot in <div class="tab-content">.

Some preliminary observations of using Stencil light DOM emulation:

Advantages Disadvantages
No issue with cross-root aria or forms association Emulation is quite experimental at the moment (and we don't know how it is a priority for stencil team
Less handle to limit overrided styles
Is it really futur proof and easily translatable into server-side code?

Other comparisons:

Styles can be scoped like any other framework which is good enough, I think.

@imagoiq imagoiq self-assigned this Mar 11, 2024
Copy link

changeset-bot bot commented Mar 11, 2024

⚠️ No Changeset found

Latest commit: f123db0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Mar 11, 2024

Preview environment ready: https://preview-2776--swisspost-design-system-next.netlify.app

Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

imagoiq added a commit that referenced this pull request Mar 14, 2024
Workaround or alternative with light DOM (but not ready to use):
#2776
@imagoiq imagoiq closed this Mar 14, 2024
@oliverschuerch oliverschuerch deleted the feat/poc-post-tabs-light-dom branch July 22, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants