Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update support for Angular 17 and ng-bootstrap 16 #2760

Merged
merged 12 commits into from
Mar 13, 2024
Merged

chore: update support for Angular 17 and ng-bootstrap 16 #2760

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f82661c
chore(demo): update Angular version
alizedebray Feb 29, 2024
050ffe6
chore(intranet-header): update Angular version
alizedebray Feb 29, 2024
2d9bd34
chore(components-angular): update Angular version
alizedebray Feb 29, 2024
2f17f63
Add changesets
alizedebray Mar 5, 2024
06a7311
Merge branch 'main' into 2301-update-support-for-angular-17
alizedebray Mar 5, 2024
7b546c1
Update pnpm-lock.yaml
alizedebray Mar 5, 2024
01b9e6e
Fix new rule with update from axe-core to 4.8.4
imagoiq Mar 7, 2024
9a58bf5
Update @angular-eslint packages
alizedebray Mar 13, 2024
280d1cf
Merge branch 'main' into 2301-update-support-for-angular-17
alizedebray Mar 13, 2024
a545405
apply patches
alizedebray Mar 13, 2024
9c686c2
Update orange-tigers-punch.md
alizedebray Mar 13, 2024
dda65f7
Update card.cy.ts
alizedebray Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/great-jobs-attend.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@swisspost/design-system-styles': major
---

Added support for Angular 17 and ng-bootstrap 16.
5 changes: 5 additions & 0 deletions .changeset/orange-tigers-punch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@swisspost/design-system-components-angular': patch
alizedebray marked this conversation as resolved.
Show resolved Hide resolved
---

Added support for Angular 17.
7 changes: 7 additions & 0 deletions .changeset/tall-ravens-ring.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@swisspost/design-system-demo': patch
'@swisspost/design-system-components-angular-workspace': patch
'@swisspost/design-system-intranet-header-workspace': patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say as well major for the intranet-header

---

Updated Angular to version 17.
6 changes: 3 additions & 3 deletions packages/components-angular/angular.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,18 +100,18 @@
"builder": "@angular-devkit/build-angular:dev-server",
"configurations": {
"production": {
"browserTarget": "consumer-app:build:production"
"buildTarget": "consumer-app:build:production"
},
"development": {
"browserTarget": "consumer-app:build:development"
"buildTarget": "consumer-app:build:development"
}
},
"defaultConfiguration": "development"
},
"extract-i18n": {
"builder": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "consumer-app:build"
"buildTarget": "consumer-app:build"
}
},
"test": {
Expand Down
27 changes: 13 additions & 14 deletions packages/components-angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,29 +10,28 @@
},
"private": true,
"dependencies": {
"@angular/animations": "16.2.12",
"@angular/common": "16.2.12",
"@angular/compiler": "16.2.12",
"@angular/core": "16.2.12",
"@angular/forms": "16.2.12",
"@angular/platform-browser": "16.2.12",
"@angular/platform-browser-dynamic": "16.2.12",
"@angular/router": "16.2.12",
"@angular/animations": "17.2.3",
"@angular/common": "17.2.3",
"@angular/compiler": "17.2.3",
"@angular/core": "17.2.3",
"@angular/forms": "17.2.3",
"@angular/platform-browser": "17.2.3",
"@angular/platform-browser-dynamic": "17.2.3",
"@angular/router": "17.2.3",
"@swisspost/design-system-styles": "workspace:6.6.4",
"@swisspost/design-system-components": "workspace:2.1.0",
"rxjs": "7.8.1",
"tslib": "2.6.2",
"zone.js": "0.14.3"
alizedebray marked this conversation as resolved.
Show resolved Hide resolved
},
"devDependencies": {
"@angular-devkit/build-angular": "16.2.12",
"@angular-devkit/build-angular": "17.2.2",
"@angular-eslint/builder": "16.3.1",
"@angular-eslint/eslint-plugin": "16.3.1",
"@angular-eslint/eslint-plugin-template": "16.3.1",
"@angular-eslint/schematics": "16.3.1",
"@angular-eslint/template-parser": "16.3.1",
alizedebray marked this conversation as resolved.
Show resolved Hide resolved
"@angular/cli": "16.2.12",
"@angular/compiler-cli": "16.2.12",
"@angular/cli": "17.2.2",
"@angular/compiler-cli": "17.2.3",
"@cypress/schematic": "2.5.1",
"@typescript-eslint/eslint-plugin": "5.62.0",
"@typescript-eslint/parser": "5.62.0",
Expand All @@ -43,7 +42,7 @@
"karma-coverage": "2.2.1",
"karma-jasmine": "5.1.0",
"karma-jasmine-html-reporter": "2.1.0",
"ng-packagr": "16.2.3",
"typescript": "4.9.5"
"ng-packagr": "17.2.0",
"typescript": "5.3.3"
}
}
4 changes: 2 additions & 2 deletions packages/components-angular/projects/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
"tslib": "2.6.2"
},
"peerDependencies": {
"@angular/common": "^16.0.0",
"@angular/core": "^16.0.0",
"@angular/common": "^16.0.0 || ^17.0.0",
"@angular/core": "^16.0.0 || ^17.0.0",
"@swisspost/design-system-components": "workspace:2.1.0"
},
"sideEffects": false
Expand Down
6 changes: 3 additions & 3 deletions packages/demo/angular.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,18 +76,18 @@
"serve": {
"builder": "@angular-devkit/build-angular:dev-server",
"options": {
"browserTarget": "design-system-demo:build"
"buildTarget": "design-system-demo:build"
},
"configurations": {
"production": {
"browserTarget": "design-system-demo:build:production"
"buildTarget": "design-system-demo:build:production"
}
}
},
"extract-i18n": {
"builder": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "design-system-demo:build"
"buildTarget": "design-system-demo:build"
}
},
"test": {
Expand Down
51 changes: 25 additions & 26 deletions packages/demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,17 @@
"lint": "ng lint"
},
"dependencies": {
"@angular/animations": "16.2.12",
"@angular/cdk": "16.2.14",
"@angular/common": "16.2.12",
"@angular/compiler": "16.2.12",
"@angular/core": "16.2.12",
"@angular/forms": "16.2.12",
"@angular/localize": "16.2.12",
"@angular/platform-browser": "16.2.12",
"@angular/platform-browser-dynamic": "16.2.12",
"@angular/router": "16.2.12",
"@ng-bootstrap/ng-bootstrap": "15.1.2",
"@angular/animations": "17.2.3",
"@angular/cdk": "17.2.1",
"@angular/common": "17.2.3",
"@angular/compiler": "17.2.3",
"@angular/core": "17.2.3",
"@angular/forms": "17.2.3",
"@angular/localize": "17.2.3",
"@angular/platform-browser": "17.2.3",
"@angular/platform-browser-dynamic": "17.2.3",
"@angular/router": "17.2.3",
"@ng-bootstrap/ng-bootstrap": "16.0.0",
"@popperjs/core": "2.11.8",
"@swimlane/ngx-datatable": "20.1.0",
"@swisspost/design-system-intranet-header": "workspace:5.0.11",
Expand All @@ -38,22 +38,21 @@
"zone.js": "0.14.3"
},
"devDependencies": {
"@angular-devkit/build-angular": "16.2.12",
"@angular-eslint/builder": "16.3.1",
"@angular-eslint/eslint-plugin": "16.3.1",
"@angular-eslint/eslint-plugin-template": "16.3.1",
"@angular-eslint/schematics": "16.3.1",
"@angular-eslint/template-parser": "16.3.1",
"@angular/cli": "16.2.12",
"@angular/compiler-cli": "16.2.12",
"@angular/elements": "16.2.12",
"@angular/language-service": "16.2.12",
"@angular-devkit/build-angular": "17.2.2",
"@angular-eslint/builder": "17.2.1",
"@angular-eslint/eslint-plugin": "17.2.1",
"@angular-eslint/eslint-plugin-template": "17.2.1",
"@angular-eslint/template-parser": "17.2.1",
"@angular/cli": "17.2.2",
"@angular/compiler-cli": "17.2.3",
"@angular/elements": "17.2.3",
"@angular/language-service": "17.2.3",
"@types/jasmine": "5.1.4",
"@types/jasminewd2": "2.0.13",
"@types/node": "18.17.19",
"@typescript-eslint/eslint-plugin": "6.20.0",
"@typescript-eslint/parser": "6.20.0",
"eslint": "8.56.0",
"@typescript-eslint/eslint-plugin": "6.21.0",
"@typescript-eslint/parser": "6.21.0",
"eslint": "8.57.0",
"jasmine-core": "5.1.1",
"jasmine-marbles": "0.9.2",
"jasmine-spec-reporter": "7.0.0",
Expand All @@ -68,7 +67,7 @@
"sass": "1.70.0",
"sockjs": "0.3.24",
"ts-node": "10.9.2",
"typescript": "5.1.6",
"typescript": "5.3.3",
"webpack": "5.90.1"
}
}
}
2 changes: 1 addition & 1 deletion packages/demo/src/app/bootstrap/components/card/post-card-demo/post-card-demo.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ <h3 class="d-inline font-weight-bold text-large m-0">Login & Sicherheit</h3>
</div>
<div class="list-group list-group-flush">
<div class="list-group-item d-flex">
<p class="mb-0">hans.muster@post.ch</p>
<p class="mb-0">hans.muster&#64;post.ch</p>
<a href="#" class="ms-auto"><span class="pi pi-3193"></span></a>
</div>
</div>
Expand Down
6 changes: 3 additions & 3 deletions packages/demo/src/app/bootstrap/components/tables/tables-demo/tables-demo.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,18 @@
<th scope="row">1</th>
<td>Mark</td>
<td>Otto</td>
<td>@mdo</td>
<td>&#64;mdo</td>
</tr>
<tr>
<th scope="row">2</th>
<td>Jacob</td>
<td>Thornton</td>
<td>@fat</td>
<td>&#64;fat</td>
</tr>
<tr>
<th scope="row">3</th>
<td colspan="2">Larry the Bird</td>
<td>@twitter</td>
<td>&#64;twitter</td>
</tr>
</tbody>
</table>
4 changes: 2 additions & 2 deletions packages/demo/src/app/common/ngb-localization/ngb-localization.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ <h3 class="bold mt-5">Internationalization</h3>

<p class="light font-curve-regular mt-4">
The internationalization of this content is done using the
<code>@angular/localize</code>
<code>&#64;angular/localize</code>
package. To do this, make sure to add
<code>import '@angular/localize/init';</code>
<code>import '&#64;angular/localize/init';</code>
to your
<code>polyfills.ts</code>
file, then use the implementation below to enable translations:
Expand Down
Loading
Loading