Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR Translation - new format on Swirle's translation branch #15

Merged

Conversation

HughMcZus
Copy link
Contributor

No description provided.

@swirle13
Copy link
Owner

There are a few changes that are in my new commits that aren't in here.

I'm unsure if your changes include these differences in french, as I don't speak it, but from what it looks like, they don't appear to contain these changes.

@swirle13
Copy link
Owner

And this is my fault. I didn't double check that keys get updated when I run the script to add additional keys. I'll do this in my following commit(s)

@HughMcZus
Copy link
Contributor Author

Done :) Thanks

Copy link
Owner

@swirle13 swirle13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far, just a few of the recent changes need to be integrated and it should be good to go after that 👍🏼

src/locales/fr/translation.json Outdated Show resolved Hide resolved
src/locales/fr/translation.json Outdated Show resolved Hide resolved
src/locales/fr/translation.json Outdated Show resolved Hide resolved
src/locales/fr/translation.json Outdated Show resolved Hide resolved
src/locales/fr/translation.json Outdated Show resolved Hide resolved
src/locales/fr/translation.json Outdated Show resolved Hide resolved
src/locales/fr/translation.json Outdated Show resolved Hide resolved
src/locales/fr/translation.json Outdated Show resolved Hide resolved
@HughMcZus HughMcZus requested a review from swirle13 September 27, 2023 18:45
Copy link
Owner

@swirle13 swirle13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you so much!

@swirle13 swirle13 merged commit 76fa90d into swirle13:translation Sep 27, 2023
@HughMcZus HughMcZus deleted the translation-fr-newformat-dedicated branch September 27, 2023 21:35
swirle13 added a commit that referenced this pull request Nov 15, 2023
swirle13 added a commit that referenced this pull request Nov 24, 2023
* Fix Home page card heights (#15)

* Update github links for issues migration

Add github issue templates from Issues repo

* Fix navbar and CardDetails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants