update from fork #10
Open
update from fork #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 2.7.0 to 2.7.1 (#310) * Upgrade Ruby version 2.4.9 to 2.4.10, 2.5.7 to 2.5.8, 2.6.5 to 2.6.6, 2.7.0 to 2.7.1 * correct SHA256 hash values for the .tar.xz files * updating Ruby version/hashes in a few missed files
Remove 2.4 (EOL)
Add initial GitHub Actions CI
Add Alpine 3.12
Ruby docker images officially provided by ruby-lang.org set `LANG` as `C.UTF-8` by default. https://hub.docker.com/r/rubylang/ruby/ https://github.com/ruby/ruby-docker-images/blob/36c5d8b68eb91e34825500e50ca677f5574401f7/Dockerfile#L3 #45 (comment) > I'd rather see something more official from either Ruby or Rails upstreams > recommending a UTF-8 locale by default than just the anecdote that it's > "more common" or "more convenient". I think it's the one so we should set it by default.
Set LANG by default
Add ruby 3.0.0-preview1
Ruby 3.0.0 is released
Update generate-stackbrew-library.sh for Ruby 3.0
Only two versions of alpine are supported at a time
Add alpine:3.13 images
[security] Update to 3.0.1, 2.7.3, 2.6.7, 2.5.9
https://www.ruby-lang.org/en/downloads/branches/ https://www.ruby-lang.org/en/news/2021/04/05/ruby-2-5-9-released/ > After this release, Ruby 2.5 reaches EOL. In other words, this is the last release of Ruby 2.5 series. We will not release Ruby 2.5.10 even if a security vulnerability is found. We recommend all Ruby 2.5 users to upgrade to Ruby 3.0, 2.7 or 2.6 immediately.
Also add "g++" during compilation (the upstream configure script looks for it, even though it doesn't appear to be used).
Add initial jq-based templating engine
Use jq's `IN()` instead of `index()`
Bump rust version
This reverts commit e76791f. I chose an inopportune time to do this. There is an upstream issue where builds on alpine arm64/v8 fail: https://bugs.ruby-lang.org/issues/20506 Example failure: https://doi-janky.infosiftr.net/job/wip/job/new/job/build-arm64v8/45573/console I believe rust-lang/rust#131221 will fix this but it is only slated for Rust 1.83
Revert "Bump rust version"
I believe this was fixed with ruby/ruby@74f94b3 https://bugs.ruby-lang.org/issues/15595 This was shipped with Ruby 2.7, so it should be unnecessary now
Remove alpine isnan/isinf workaround
As customary, drop alpine 3.19
Add alpine 3.21
Per https://stackoverflow.com/questions/1381725/how-to-make-no-ri-no-rdoc-the-default-for-gem-install#comment22636260_7662245 this is possible since rubygems 2.0.0 from 2012. I updated the comment to indicate this is only for the `gem` command, bundler already doesn't do this by default. It works: ``` $ gem install rubocop -v 1.69.0 Fetching rubocop-1.69.0.gem Successfully installed rubocop-1.69.0 1 gem installed $ gem update rubocop Updating installed gems Updating rubocop Fetching rubocop-1.69.1.gem Successfully installed rubocop-1.69.1 Gems updated: rubocop ```
Simplify gemrc nodoc
This makes it print out a diff when there is an error (instead of just a list of files that are wrong), which will make the error more obvious. I also added `workflow_dispatch` so we can run it manually.
These were never intended to be part of the "interface" of the `slim` and `alpine` images -- they were included before we had fancy `ldd`/`scanelf`-based runtime dependency inclusion, and were a metapackage that helped us avoid the complexity of `libyaml3` vs `libyaml4` (and making sure we install the correct one). This moves them to explicit build-time dependencies accordingly, as they should've always been.
This is a redo of #478, now that there are no compilation issues for some platforms anymore. See https://bugs.ruby-lang.org/issues/20506
Bump Rust to 1.84.0
Remove runtime dependencies from slim and alpine variants
This reverts commit 7f078b1. It looks like this change is too disruptive. For example, modern rails apps all depend in `psych` which requires libyaml. I still think it makes sense, but should probably only be part of the next Ruby version so it doesn't suddently break for lots of people.
This adjusts the backwards-compatibility shim to be easier to remove in the future (and automatically removes it at each next minor release).
Revert "Remove runtime dependencies from slim and alpine variants"
Since Ruby 2.7, this warning is not emitted anymore It was removed as part of https://bugs.ruby-lang.org/issues/16131 Here's the output of running `ENV['PATH']` against various ruby versions, when `$PATH` contains a world-writable folder: ``` ===============1.8.7-p374================ -e:1: warning: Insecure world writable dir /app/whatever in PATH, mode 040757 ===============1.9.3-p551================ -e:1: warning: Insecure world writable dir /app/whatever in PATH, mode 040757 ===============2.0.0-p648================ -e:1: warning: Insecure world writable dir /app/whatever in PATH, mode 040757 =================2.1.10================== -e:1: warning: Insecure world writable dir /app/whatever in PATH, mode 040757 =================2.2.10================== -e:1: warning: Insecure world writable dir /app/whatever in PATH, mode 040757 ==================2.3.8================== -e:1: warning: Insecure world writable dir /app/whatever in PATH, mode 040757 =================2.4.10================== -e:1: warning: Insecure world writable dir /app/whatever in PATH, mode 040757 ==================2.5.9================== -e:1: warning: Insecure world writable dir /app/whatever in PATH, mode 040757 =================2.6.10================== -e:1: warning: Insecure world writable dir /app/whatever in PATH, mode 040757 ==================2.7.8================== ==================3.0.7================== ==================3.1.6================== ==================3.2.6================== ==================3.3.6================== ================3.4.0-rc1================ ``` In https://bugs.ruby-lang.org/issues/20971, it was OKed to officially deprecate since not emitting this was unintentional at the time
Remove `ENABLE_PATH_CHECK` workaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.