Indeterminate Checkbox #1083
Merged
Indeterminate Checkbox #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkColeman1
requested changes
Feb 3, 2025
| background-color: colors.$color-blue-400; | ||
| border-radius: 2px; | ||
| opacity: 1; | ||
| border: 2px solid colors.$color-blue-400; | ||
| transform: rotate(0deg) scale(1); | ||
|
|
||
| &:after { |
There was a problem hiding this comment.
This :after is missing the content property.
There was a problem hiding this comment.
It inherits content from above.
MarkColeman1
approved these changes
Feb 4, 2025
steveblue
added a commit
that referenced
this pull request
Feb 11, 2025
* feat: angular 19 * feat: angular cdk upgrade * fix: sass refactor * fix: update peer dependencies * fix: CHANGELOG * feat: rename color files for consistency * feat: new color files * feat: version bump * feat: Indeterminate Checkbox (#1083) * fix: position of check mark when checked set to true * fix: upgrade ng2-file-upload * feat: migrate to yarn * fix: moment issues * fix: ngx-time * fix: format and lint * fix: tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces an
indeterminatestate for ngx-checkbox, mirroring the native browser behavior ofinput[type="checkbox"]when put in the sameindeterminatestate.In summary, a checkbox should be able to display
indeterminateregardless ofvalue.indeterminateshould not setvalue(orchecked), but it should override the look and feel.indeterminateshould only be set externally and any form handling should account for special cases involvingindeterminate.ngx-checkbox): a new look is available that displays theindeterminatestate.ngx-checkbox): new@Inputnamedindeterminateset to aboolean.ngx-checkbox): implements anEventEmitterwhenindeterminatechanges.ngx-checkbox): position of check mark when checked set to true.indeterminate.checkbox.mov
Checklist
/projects/swimlane/ngx-ui/CHANGELOG.mdunder HEAD (Unreleased)*required