Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress Bar Post #65

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

krzykamil
Copy link

@krzykamil krzykamil commented Jan 3, 2024

Article about progress bar, with example implementation based on my personal repository https://github.com/krzykamil/libus

Copy link

vercel bot commented Jan 3, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @swilgosz on Vercel.

@swilgosz first needs to authorize it.

Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
hanamimastery ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2024 11:17pm

data/articles/progress-bar.md Outdated Show resolved Hide resolved
ruby: null
rails: null
hanamirb: null
source:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give me a pointer to the source code? Before vs After diff would be amazing.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/krzykamil/libus/commits/master/ This is the full repo
I haven't done it all in one commit, since it would be huge (and I was trying different approaches along the way), but the most important commit is this one, since it is the gone that gives a full working state for the first time, with the persistence layer added krzykamil/libus@4abab20
The commits after that are refactors, cleanup and rom-factory setup

data/articles/progress-bar.md Outdated Show resolved Hide resolved
data/articles/progress-bar.md Outdated Show resolved Hide resolved
data/articles/progress-bar.md Outdated Show resolved Hide resolved
data/articles/progress-bar.md Outdated Show resolved Hide resolved
@swilgosz
Copy link
Owner

swilgosz commented Jan 3, 2024

Thank you soo much for this!

@krzykamil krzykamil changed the title Progress Bar Post [WIP] Progress Bar Post Jan 4, 2024
@krzykamil krzykamil marked this pull request as ready for review January 4, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants