Move carton command implementation into CartonDriver module #459
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
課題
carton
コマンドはmain.swift
に実装が書かれています。しかし、executable targetに実装を書くと、それがテストしづらくなります。
テストターゲットが executable target に依存すると、
しばしばリンクの問題が生じるからです。
最近はSwiftPMが頑張っているのでビルドできたりしますが、
Wasmターゲットなど新たな環境では壊れたりします。
それも最近直されたりはしましたが、将来のリスクはあるでしょう。
提案
CartonModule
モジュールを導入し、cartonコマンドの実装を全て移します。carton
executable targetはそれをimportしてエントリポイントを呼び出すだけにします。