Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create LICENSE #2

Merged
merged 1 commit into from
Dec 26, 2020
Merged

Create LICENSE #2

merged 1 commit into from
Dec 26, 2020

Conversation

MaxDesiatov
Copy link
Contributor

This apparently contains some pieces of webidl2swift, which is licensed under MIT. JavaScriptKit is licensed under MIT too. OTOH, we could include a separate MIT license for webidl2swift bits and license everything else under Apache 2.0 for consistency with the rest of our organization. WDYT?

@MaxDesiatov MaxDesiatov added the documentation Improvements or additions to documentation label Dec 26, 2020
@MaxDesiatov MaxDesiatov requested a review from a team December 26, 2020 18:47
carson-katri
carson-katri approved these changes Dec 26, 2020
View reviewed changes
Copy link
Member

@carson-katri carson-katri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just MIT is a good choice. Just my opinion though 🤷‍♂️

@MaxDesiatov MaxDesiatov requested a review from a team December 26, 2020 19:20
j-f1
j-f1 approved these changes Dec 26, 2020
View reviewed changes
Copy link
Member

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to license everything in this repo to which I own the copyright under the MIT license

@MaxDesiatov MaxDesiatov merged commit c62aafd into main Dec 26, 2020
@MaxDesiatov MaxDesiatov deleted the add-license branch December 26, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-f1 j-f1 j-f1 approved these changes

@carson-katri carson-katri carson-katri approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxDesiatov @carson-katri @j-f1