WebIDLToSwift: Generate single file to make output filenames predictable #19
Conversation
Sources/WebIDLToSwift/main.swift
Outdated
| @@ -9,14 +9,18 @@ func main() { | |||
| let idl = try IDLParser.parseIDL() | |||
| print("Removing old files...") | |||
| try IDLBuilder.cleanOutputFolder() | |||
There was a problem hiding this comment.
I think we should have a Sources/DOMKit/Generated.swift file and then move all the Sources/DOMKit/ECMAScript/* files to the root of DOMKit. That would mean there would be no need to delete anything anymore
There was a problem hiding this comment.
I think most of DOMKit/ECMAScript/* should be moved to JavaScriptKit because they are independent of DOM spec.
But for now, I want to move them to a separate ECMAScript module in this repo to be used in multiple modules after split-out.
There was a problem hiding this comment.
Yeah, I definitely think there’s a place for a third module (or in JSKit? idk) that exposes the full ECMAScript APIs that are not part of the DOM.
This shouldn't conflict much with #19, as it generates a single `console.swift` file. Co-authored-by: Jed Fox <[email protected]>
MaxDesiatov
changed the title
|
Sorry about the conflicts, it's ready for merging now 🙂 |
kateinoigakukun
force-pushed
the
katei/generate-single-file
branch
from
a2745ed
to
c2bee0a
Compare
No description provided.