Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): use source instead of . in fish #105

Merged
merged 1 commit into from
May 15, 2024

Conversation

kkebo
Copy link
Contributor

@kkebo kkebo commented May 9, 2024

fixes #104

This is a follow-up pull request of #91.

This pull request doesn't contain changes for fish users who have already installed swiftly.

Checks

I also checked output files and output messages in addition to docker compose up install-test.

$ rm -rf ~/.local/bin/swiftly ~/.config/fish/conf.d/swiftly.fish ~/.local/share/swiftly
$ ./install/swiftly-install.sh --no-install-system-deps
Fedora Linux Asahi Remix 39 (Thirty Nine) is not an officially supported platform, but the toolchains for another platform may still work on it.

Please select the platform to use for toolchain downloads:
0) Cancel
1) Ubuntu 22.04
2) Ubuntu 20.04
3) Ubuntu 18.04
4) RHEL 9
5) Amazon Linux 2
> 1
This script will install swiftly, a Swift toolchain installer and manager.

Current installation options:

    Data and configuration files directory: $HOME/.local/share/swiftly
        Executables installation directory: $HOME/.local/bin
  Modify login config ($HOME/.config/fish/conf.d/swiftly.fish): true
               Install system dependencies: false

Select one of the following:
1) Proceed with the installation (default)
2) Customize the installation
3) Cancel
> 1
Downloading swiftly from https://github.com/swift-server/swiftly/releases/latest/download/swiftly-aarch64-unknown-linux-gnu...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 55.9M  100 55.9M    0     0  10.5M      0  0:00:05  0:00:05 --:--:-- 11.1M

Importing Swift's PGP keys...
gpg: key D441C977412B37AD: "Swift Automatic Signing Key #1 <[email protected]>" not changed
gpg: key 9F597F4D21A56D5F: "Swift 2.2 Release Signing Key <[email protected]>" not changed
gpg: key 63BC1CFE91D306C6: "Swift 3.x Release Signing Key <[email protected]>" not changed
gpg: key EF5430F071E1B235: "Swift 4.x Release Signing Key <[email protected]>" not changed
gpg: key 7638F1FB2B2B08C4: "Swift Automatic Signing Key #2 <[email protected]>" not changed
gpg: key 925CC1CCED3D1561: "Swift 5.x Release Signing Key <[email protected]>" not changed
gpg: key FAF6989E1BC16FEA: "Swift Automatic Signing Key #3 <[email protected]>" not changed
gpg: key 925CC1CCED3D1561: "Swift 5.x Release Signing Key <[email protected]>" not changed
gpg: key F167DF1ACF9CE069: "Swift Automatic Signing Key #4 <[email protected]>" not changed
gpg: key 925CC1CCED3D1561: "Swift 5.x Release Signing Key <[email protected]>" not changed
gpg: key F167DF1ACF9CE069: "Swift Automatic Signing Key #4 <[email protected]>" not changed
gpg: Total number processed: 11
gpg:              unchanged: 11

swiftly has been successfully installed!

Once you log in again, swiftly should be accessible from your PATH.
To begin using swiftly from your current shell, first run the following command:

    source $HOME/.local/share/swiftly/env.fish

Then to install the latest version of Swift, run 'swiftly install latest'
$ cat ~/.config/fish/conf.d/swiftly.fish
source $HOME/.local/share/swiftly/env.fish

@patrickfreed
Copy link
Contributor

@swift-server-bot test install please

@kkebo
Copy link
Contributor Author

kkebo commented May 15, 2024

This failure was expected, right?

https://ci.swiftserver.group/job/swiftly-ubuntu1804-install-prb/35/console

@patrickfreed
Copy link
Contributor

Yeah, swift stopped publishing releases for Ubuntu 18.04 and we upgraded our testing to use Swift 5.10, so the 18.04 ones always fail (see #100). I'll take a look at fixing those today.

@patrickfreed patrickfreed merged commit 55e261d into swiftlang:main May 15, 2024
4 of 5 checks passed
@patrickfreed
Copy link
Contributor

Changes look great to me, thanks again for the contribution!

@kkebo kkebo deleted the fish-source branch May 15, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fish: . is deprecated
2 participants