Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix existential specializer for unowned ownership" #77963

Closed
wants to merge 1 commit into from

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Dec 4, 2024

Reverts #77933

This might be causing #77955

@compnerd compnerd requested a review from eeckstein as a code owner December 4, 2024 21:53
@compnerd
Copy link
Member Author

compnerd commented Dec 4, 2024

@swift-ci please smoke test

@meg-gupta
Copy link
Contributor

@compnerd It doesn't look like #77933 is in the blamelist for https://ci-external.swift.org/job/swift-main-windows-toolchain/867/

@hjyamauchi
Copy link
Contributor

I reduced it to a small test: #77955

@compnerd
Copy link
Member Author

compnerd commented Dec 4, 2024

@meg-gupta sure, but, we don't have a specific change that we can pin it to right now. Consider https://ci-external.swift.org/job/swift-PR-windows/33954/ ... the change is to a shell expansion and it shows up with the same thing. Whatever the cause is, it is preventing any changes from going in.

@compnerd
Copy link
Member Author

compnerd commented Dec 4, 2024

Seems that this happens on a 11/20 snapshot so this is not a recent change. It is possible that a DocC change is triggering this (thanks to @hjyamauchi for testing against the snapshot!).

@compnerd compnerd closed this Dec 4, 2024
@compnerd compnerd deleted the revert-77933-fixexistential branch December 4, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants