Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TaskLocal documentation issue #77943

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Fix TaskLocal documentation issue #77943

merged 2 commits into from
Dec 4, 2024

Conversation

Kyle-Ye
Copy link
Contributor

@Kyle-Ye Kyle-Ye commented Dec 4, 2024 •
edited
Loading

Fix some documentation issue on TaskLocal

@Kyle-Ye Kyle-Ye requested a review from ktoso as a code owner December 4, 2024 06:47
@Kyle-Ye Kyle-Ye changed the title Update TaskLocal.swift documentation Fix typo in TaskLocal documentation Dec 4, 2024
@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Dec 4, 2024

@swift-ci test

ktoso
ktoso reviewed Dec 4, 2024
View reviewed changes
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ktoso
Copy link
Contributor

ktoso commented Dec 4, 2024

@swift-ci please smoke test

@ktoso ktoso enabled auto-merge December 4, 2024 06:49
@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Dec 4, 2024

Thanks for the quick response.

Also note another issue here:

The TaskLocal-macro is not working as expected here

SCR-20241204-nelh

We have a correct usage in Observable by using ``Observation/Observable()``.

And we should use ``_Concurrency/TaskLocal()-swift.macro`` to refer the macro.

  • _Concurrency can be omitted since we are in the same module
  • -swift and .macro can also be omitted here as there is no conflict

Source: https://www.swift.org/documentation/docc/linking-to-symbols-and-other-content

@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Dec 4, 2024

@swift-ci please smoke test

@Kyle-Ye Kyle-Ye changed the title Fix typo in TaskLocal documentation Fix TaskLocal documentation issue Dec 4, 2024
@Kyle-Ye Kyle-Ye mentioned this pull request Dec 4, 2024
Merged
3 tasks
@ktoso
Copy link
Contributor

ktoso commented Dec 4, 2024

@swift-ci please smoke test

@ktoso ktoso merged commit 22741db into main Dec 4, 2024
3 checks passed
@ktoso ktoso deleted the Kyle-Ye-patch-1 branch December 4, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktoso ktoso ktoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kyle-Ye @ktoso