[5.10][Macros] Add option to disable sandbox for exectuable plugins #70079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`-disable-sandbox` to disable sandboxing when invoking subprocess from from the frontend. Since `sandbox(7)` in macOS doesn't support nested sandbox, complation used to fail when the parent build process is sandboxed. (cherry picked from commit 0c9f099) Conflicts: lib/Frontend/ArgsToFrontendOptionsConverter.cpp
|
@swift-ci Please test |
bnbarham
approved these changes
Nov 29, 2023
keith
pushed a commit
to bazelbuild/rules_swift
that referenced
this pull request
May 22, 2024
…xing (#1206) This should solve #1202 and #1204 > There were issues with Swift compiler plugins (incl. macros) and nested sandboxes on macOS with Swift 5.9 that have been fixed with 5.10: > swift: [swiftlang/swift#70079](swiftlang/swift#70079) > swift-driver: [swiftlang/swift-driver#1493](swiftlang/swift-driver#1493) > swift-package-manager: [swiftlang/swift-package-manager#7167](swiftlang/swift-package-manager#7167) I am not sure whether this flag is required on Linux too. --------- Signed-off-by: Adin Cebic <[email protected]> Co-authored-by: Brentley Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #70046 into release/5.10
-disable-sandboxto disable sandboxing when invoking subprocess. Sincesandbox(7)in macOS doesn't support nested sandbox, compilations used to fail when the parent build process is sandboxed.